Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add runOnRecordSegmentComplete and rclone integration (#2404) #2428

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Sep 27, 2023

Fixes #2404

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2428 (8212487) into main (2d929e1) will decrease coverage by 0.08%.
The diff coverage is 51.11%.

@@            Coverage Diff             @@
##             main    #2428      +/-   ##
==========================================
- Coverage   61.94%   61.86%   -0.08%     
==========================================
  Files         129      129              
  Lines       14515    14537      +22     
==========================================
+ Hits         8991     8993       +2     
- Misses       4857     4874      +17     
- Partials      667      670       +3     
Files Coverage Δ
internal/record/cleaner.go 87.50% <ø> (-0.16%) ⬇️
internal/record/segment.go 77.55% <100.00%> (+1.46%) ⬆️
internal/record/agent.go 30.59% <81.81%> (-0.10%) ⬇️
internal/conf/path.go 27.49% <55.55%> (-0.68%) ⬇️
internal/core/path.go 75.24% <7.69%> (-1.32%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 changed the title add runOnRecordSegmentDone to allow rclone integration (#2404) add runOnRecordSegmentComplete and rclone integration (#2404) Sep 28, 2023
@aler9 aler9 force-pushed the feature/rec branch 3 times, most recently from 3888a52 to 2d246b0 Compare September 29, 2023 16:15
@aler9 aler9 merged commit eb97502 into main Sep 29, 2023
6 of 8 checks passed
@aler9 aler9 deleted the feature/rec branch September 29, 2023 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Support recording to FTP / SFTP remote storage
1 participant