Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting different recording parameters for each path (#2410) #2457

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Oct 4, 2023

Fixes #2410

@aler9 aler9 force-pushed the feature/recsettings branch 2 times, most recently from 874f7ac to eb8c14a Compare October 5, 2023 20:20
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #2457 (396e4d8) into main (9a01ab7) will decrease coverage by 0.09%.
The diff coverage is 67.50%.

@@            Coverage Diff             @@
##             main    #2457      +/-   ##
==========================================
- Coverage   61.50%   61.41%   -0.09%     
==========================================
  Files         133      133              
  Lines       14876    14896      +20     
==========================================
- Hits         9150     9149       -1     
- Misses       5044     5058      +14     
- Partials      682      689       +7     
Files Coverage Δ
internal/core/path.go 75.00% <100.00%> (-0.21%) ⬇️
internal/core/path_manager.go 89.83% <ø> (-0.22%) ⬇️
internal/record/cleaner.go 87.95% <94.73%> (+0.45%) ⬆️
internal/conf/path.go 34.33% <70.00%> (+1.00%) ⬆️
internal/core/core.go 85.69% <82.75%> (-0.48%) ⬇️
internal/conf/conf.go 64.37% <0.00%> (-4.08%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 force-pushed the feature/recsettings branch 2 times, most recently from d66fc55 to 61d24eb Compare October 7, 2023 21:39
@aler9 aler9 merged commit 8a633d2 into main Oct 7, 2023
7 of 8 checks passed
@aler9 aler9 deleted the feature/recsettings branch October 7, 2023 21:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuring recording per paths
1 participant