Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash when publishing to a path with 'runOnDemand' from outside 'runOnDemand' (#2636) #2637

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Nov 3, 2023

Fixes #2636

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2637 (15737a8) into main (39a239c) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 86.20%.

@@            Coverage Diff             @@
##             main    #2637      +/-   ##
==========================================
- Coverage   59.34%   59.29%   -0.05%     
==========================================
  Files         144      144              
  Lines       15228    15216      -12     
==========================================
- Hits         9037     9023      -14     
  Misses       5556     5556              
- Partials      635      637       +2     
Files Coverage Δ
internal/core/path.go 62.07% <86.20%> (+0.21%) ⬆️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@aler9 aler9 merged commit 4f876ed into main Nov 3, 2023
7 of 8 checks passed
@aler9 aler9 deleted the bug/ondemand branch November 3, 2023 15:54
Copy link
Contributor

This issue is mentioned in release v1.3.0 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when publishing to a path with runOnDemand without any clients reading
1 participant