Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: restore compatibility when running behind a proxy, in a subpath #2638

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Nov 3, 2023

No description provided.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2638 (7ffc431) into main (4f876ed) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2638      +/-   ##
==========================================
- Coverage   59.33%   59.30%   -0.04%     
==========================================
  Files         144      144              
  Lines       15216    15217       +1     
==========================================
- Hits         9028     9024       -4     
- Misses       5551     5556       +5     
  Partials      637      637              
Files Coverage Δ
internal/core/webrtc_http_server.go 69.58% <100.00%> (+0.12%) ⬆️

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@aler9 aler9 merged commit faf7218 into main Nov 3, 2023
7 of 8 checks passed
@aler9 aler9 deleted the bug/webrtc-subpath branch November 3, 2023 16:36
Copy link
Contributor

This issue is mentioned in release v1.3.0 🚀
Check out the entire changelog by clicking here

@LeRatierBretonnien
Copy link

Hi.
Using v1.3.0, and I am not sure if it has been fixed.
Proxying with apache in a subfolder does not work : error 404 is returned. Direct access to the WebRTC stream thru the 8889 port is working.
Any hint/idea ?
Thanks.

@aler9
Copy link
Member Author

aler9 commented Nov 16, 2023

@LeRatierBretonnien this is not the way to report bugs. Open an issue and provide details on how to replicate.

@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants