Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: fix bad quality when converting Opus from WebRTC to LL-HLS (#2499) #2740

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Nov 24, 2023

Fixes #2499

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (db5ba99) 59.88% compared to head (b1ae234) 59.90%.

Files Patch % Lines
internal/protocols/webrtc/incoming_track.go 0.00% 1 Missing ⚠️
internal/staticsources/hls/source.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2740      +/-   ##
==========================================
+ Coverage   59.88%   59.90%   +0.02%     
==========================================
  Files         144      144              
  Lines       15331    15332       +1     
==========================================
+ Hits         9181     9185       +4     
+ Misses       5507     5504       -3     
  Partials      643      643              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 81c803b into main Nov 24, 2023
8 of 9 checks passed
@aler9 aler9 deleted the bug/webrtc-hls-stereo branch November 24, 2023 21:07
Copy link
Contributor

This issue is mentioned in release v1.3.1 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When ingesting WHIP, Audio on LL-HLS is always Mono and very bad
1 participant