Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtmp: fix parsing error caused by extended timestamps (#2393) (#2556) (#2384) (#1550) (#2564) #2808

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Dec 14, 2023

Fixes #2393
Fixes #2556
Fixes #2384
Fixes #1550
Fixes #2564

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (22414bb) 56.95% compared to head (f50cc05) 57.29%.

Files Patch % Lines
internal/protocols/rtmp/chunk/chunk0.go 93.87% 2 Missing and 1 partial ⚠️
internal/protocols/rtmp/chunk/chunk1.go 92.68% 2 Missing and 1 partial ⚠️
internal/protocols/rtmp/chunk/chunk2.go 90.62% 2 Missing and 1 partial ⚠️
internal/protocols/rtmp/chunk/chunk3.go 86.95% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2808      +/-   ##
==========================================
+ Coverage   56.95%   57.29%   +0.33%     
==========================================
  Files         125      125              
  Lines       11398    11507     +109     
==========================================
+ Hits         6492     6593     +101     
- Misses       4401     4405       +4     
- Partials      505      509       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This issue is mentioned in release v1.4.1 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.