Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoints for managing recordings #2901

Closed
wants to merge 7 commits into from

Conversation

eravellaSC
Copy link

This is a WIP pull request (I am still working on the whole feature) that I am posting to ask if it makes sense to have this API extension. The aim here would be having some interface to manage the recorded streams via the REST API, allowing operations as

  • listing
  • deletion
  • streaming (still need to be added, I am trying to figure out how to stream from file or if it is easier to just create a stream and run an FFMPEG script)

Does this feature make sense?

@bog
Copy link

bog commented Jan 12, 2024

This is something I'd be very interested in.

@eravellaSC eravellaSC mentioned this pull request Jan 15, 2024
2 tasks
@eravellaSC
Copy link
Author

I added tests and refactored some code. I think that the steaming back functionality is being addressed in #2906 (and it's still achievable through the already existing API and the use of hooks). I will wait for review and if there are things that need to be adjusted I will work on them.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (cf68fe4) 53.18% compared to head (6090fc6) 51.86%.
Report is 29 commits behind head on main.

Files Patch % Lines
internal/api/api.go 0.00% 60 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2901      +/-   ##
==========================================
- Coverage   53.18%   51.86%   -1.32%     
==========================================
  Files         124      130       +6     
  Lines       11448    12682    +1234     
==========================================
+ Hits         6089     6578     +489     
- Misses       4905     5611     +706     
- Partials      454      493      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t3therdev
Copy link

Hi @eravellaSC playback is released in 1.5. I think your suggested API enhancements would work well also.

@aler9
Copy link
Member

aler9 commented Jan 23, 2024

sorry for not including this in 1.5 but i had no time for reviewing it. Will do ASAP.

@eravellaSC
Copy link
Author

Not a problem for me. Let me know if further work is needed / if I can help with something

apidocs/openapi.yaml Outdated Show resolved Hide resolved
Co-authored-by: Talha Khan <talha@averred.net>
@aler9
Copy link
Member

aler9 commented Feb 4, 2024

Unfortunately this PR lacks some critical features, including:

  • handling segments of paths that use a recordPath value different from the one in defaultPaths
  • retrieving path names
  • segment management independent from file paths on disk
  • pagination

i've created a new patch here: #2988

Copy link
Contributor

github-actions bot commented Feb 4, 2024

This issue is mentioned in release v1.5.1 🚀
Check out the entire changelog by clicking here

@eravellaSC
Copy link
Author

@aler9 I'm sorry for making you do additional work, I am not very used to golang and I am still studying the internals of MediaMTX. Thanks for the new release though.

@aler9
Copy link
Member

aler9 commented Feb 5, 2024

thank you for providing the idea behind the feature.

@eravellaSC eravellaSC deleted the feature/recordingsAPI branch May 2, 2024 06:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants