-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoints for managing recordings #2901
Conversation
This is something I'd be very interested in. |
I added tests and refactored some code. I think that the steaming back functionality is being addressed in #2906 (and it's still achievable through the already existing API and the use of hooks). I will wait for review and if there are things that need to be adjusted I will work on them. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2901 +/- ##
==========================================
- Coverage 53.18% 51.86% -1.32%
==========================================
Files 124 130 +6
Lines 11448 12682 +1234
==========================================
+ Hits 6089 6578 +489
- Misses 4905 5611 +706
- Partials 454 493 +39 ☔ View full report in Codecov by Sentry. |
Hi @eravellaSC playback is released in 1.5. I think your suggested API enhancements would work well also. |
sorry for not including this in 1.5 but i had no time for reviewing it. Will do ASAP. |
Not a problem for me. Let me know if further work is needed / if I can help with something |
Co-authored-by: Talha Khan <talha@averred.net>
Unfortunately this PR lacks some critical features, including:
i've created a new patch here: #2988 |
This issue is mentioned in release v1.5.1 🚀 |
@aler9 I'm sorry for making you do additional work, I am not very used to golang and I am still studying the internals of MediaMTX. Thanks for the new release though. |
thank you for providing the idea behind the feature. |
This is a WIP pull request (I am still working on the whole feature) that I am posting to ask if it makes sense to have this API extension. The aim here would be having some interface to manage the recorded streams via the REST API, allowing operations as
Does this feature make sense?