Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playback: accept durations written in seconds #2979

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Feb 3, 2024

No description provided.

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e6bf095) 51.96% compared to head (15d7196) 51.98%.

Files Patch % Lines
internal/playback/server.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2979      +/-   ##
==========================================
+ Coverage   51.96%   51.98%   +0.01%     
==========================================
  Files         131      131              
  Lines       12875    12881       +6     
==========================================
+ Hits         6691     6696       +5     
- Misses       5654     5655       +1     
  Partials      530      530              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit ff70f90 into main Feb 3, 2024
8 checks passed
@aler9 aler9 deleted the feature/duration branch February 3, 2024 15:05
Copy link
Contributor

github-actions bot commented Feb 4, 2024

This issue is mentioned in release v1.5.1 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant