Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when stopping hooks, stop all their subprocesses too (#3004) #3087

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Feb 29, 2024

Fixes #3004

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.25%. Comparing base (a40ca33) to head (ec1a6a9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3087   +/-   ##
=======================================
  Coverage   55.25%   55.25%           
=======================================
  Files         149      149           
  Lines       16463    16463           
=======================================
  Hits         9097     9097           
  Misses       6647     6647           
  Partials      719      719           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 44918fc into main Feb 29, 2024
8 checks passed
@aler9 aler9 deleted the feature/kill-subprocesses branch February 29, 2024 21:42
Copy link
Contributor

github-actions bot commented Mar 4, 2024

This issue is mentioned in release v1.6.0 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runOnDemand command doesn't stop the processes executed from the win10 batch
1 participant