Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: fix deadlock when a WHEP source fails (#3062) (#3108) #3110

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

RouquinBlanc
Copy link
Contributor

Tentative for fixing #3108.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 55.58%. Comparing base (dd3b268) to head (9fa8b3f).

Files Patch % Lines
internal/protocols/webrtc/peer_connection.go 77.77% 2 Missing ⚠️
internal/protocols/webrtc/whip_client.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3110      +/-   ##
==========================================
+ Coverage   55.10%   55.58%   +0.48%     
==========================================
  Files         150      150              
  Lines       16819    16822       +3     
==========================================
+ Hits         9268     9351      +83     
+ Misses       6824     6733      -91     
- Partials      727      738      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 changed the title fix: whep deadlock on network issues fix: whep deadlock on network issues (#3062) (#3108) Mar 6, 2024
This was linked to issues Mar 6, 2024
@aler9
Copy link
Member

aler9 commented Mar 6, 2024

Thanks for reporting the issue and for posting the patch. I improved performance and added tests. This has been merged, thanks!

@aler9 aler9 changed the title fix: whep deadlock on network issues (#3062) (#3108) webrtc: fix deadlock when a WHEP source fails (#3062) (#3108) Mar 6, 2024
@aler9 aler9 merged commit 732bf56 into bluenviron:main Mar 6, 2024
8 checks passed
@RouquinBlanc RouquinBlanc deleted the fix-deadlock-whep-source branch March 7, 2024 00:08
Copy link
Contributor

This issue is mentioned in release v1.7.0 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WHEP source ends up in deadlock WHEP Source auto reconnection
2 participants