Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not switch to legacy authentication system when readUser, readPass, publishUser, publishPass are present but are empty #3113

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Mar 6, 2024

No description provided.

…, publishUser, publishPass are present but are empty
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 55.09%. Comparing base (bb46640) to head (bd99734).
Report is 4 commits behind head on main.

Files Patch % Lines
internal/conf/path.go 0.00% 6 Missing ⚠️
internal/conf/conf.go 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3113      +/-   ##
==========================================
+ Coverage   55.07%   55.09%   +0.02%     
==========================================
  Files         150      150              
  Lines       16811    16819       +8     
==========================================
+ Hits         9258     9267       +9     
+ Misses       6826     6825       -1     
  Partials      727      727              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit dd3b268 into main Mar 6, 2024
8 checks passed
@aler9 aler9 deleted the fix/credentials-legacy branch March 6, 2024 17:04
Copy link
Contributor

This issue is mentioned in release v1.7.0 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant