Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for ICE servers to be client only #3164

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

dbason
Copy link
Contributor

@dbason dbason commented Mar 25, 2024

Fixes #3145

The config update will not change the default behaviour. It does however allow the asymmetric model. This is how LiveKit uses TURN servers for example.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 55.69%. Comparing base (ac14a2f) to head (0c72f7b).
Report is 7 commits behind head on main.

Files Patch % Lines
internal/servers/webrtc/server.go 47.36% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3164      +/-   ##
==========================================
+ Coverage   55.65%   55.69%   +0.03%     
==========================================
  Files         151      151              
  Lines       16874    16875       +1     
==========================================
+ Hits         9391     9398       +7     
+ Misses       6744     6738       -6     
  Partials      739      739              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbason
Copy link
Contributor Author

dbason commented Mar 25, 2024

I think there might be a race condition in the failing test. I have noticed that one other open PR is also failing on the same thing.

@aler9 aler9 merged commit 87c0535 into bluenviron:main Apr 6, 2024
8 checks passed
@aler9
Copy link
Member

aler9 commented Apr 6, 2024

merged, thanks!

Copy link
Contributor

This issue is mentioned in release v1.7.0 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support asymmetric ICE
2 participants