Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unexpected behavior of authInternalUsers or authHTTPExclude #3316

Merged
merged 1 commit into from
May 4, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented May 4, 2024

when some subfields of authInternalUsers and authHTTPExclude were not set explicitly in the configuration file, default values were used in their place. This is caused by a strange behavior of Go (golang/go#21092)

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.66%. Comparing base (8b51ca9) to head (d882d1f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3316      +/-   ##
==========================================
+ Coverage   52.63%   52.66%   +0.03%     
==========================================
  Files         191      193       +2     
  Lines       19996    20011      +15     
==========================================
+ Hits        10525    10539      +14     
- Misses       8614     8615       +1     
  Partials      857      857              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

when some subfields of authInternalUsers or authHTTPExclude were not
set explicitly in the configuration file, default values were used in
their place. This is caused by a strange behavior of Go
(golang/go#21092)
@aler9 aler9 merged commit 575d358 into main May 4, 2024
8 checks passed
@aler9 aler9 deleted the fix/auth2 branch May 4, 2024 08:12
Copy link
Contributor

github-actions bot commented May 5, 2024

This issue is mentioned in release v1.8.1 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant