Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: in answer, include codecs that are actually in use #3374

Merged
merged 1 commit into from
May 19, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented May 19, 2024

No description provided.

@aler9 aler9 changed the title webrtc: include in answers only codecs that are actually in use webrtc: include in answers codecs that are actually in use only May 19, 2024
Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 34.84163% with 144 lines in your changes are missing coverage. Please review.

Project coverage is 53.85%. Comparing base (0ace308) to head (e06a0cc).

Files Patch % Lines
internal/protocols/webrtc/outgoing_track.go 0.00% 74 Missing ⚠️
internal/protocols/webrtc/peer_connection.go 42.85% 41 Missing and 7 partials ⚠️
internal/protocols/webrtc/whip_client.go 0.00% 18 Missing ⚠️
internal/servers/webrtc/session.go 87.09% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3374      +/-   ##
==========================================
+ Coverage   53.80%   53.85%   +0.05%     
==========================================
  Files         191      190       -1     
  Lines       18832    18829       -3     
==========================================
+ Hits        10132    10140       +8     
+ Misses       7905     7893      -12     
- Partials      795      796       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 changed the title webrtc: include in answers codecs that are actually in use only webrtc: include in answer codecs that are actually in use May 19, 2024
@aler9 aler9 changed the title webrtc: include in answer codecs that are actually in use webrtc: in answer, include codecs that are actually in use May 19, 2024
@aler9 aler9 merged commit 4077023 into main May 19, 2024
7 of 8 checks passed
@aler9 aler9 deleted the fix/webrtc-codecs branch May 19, 2024 17:41
Copy link
Contributor

This issue is mentioned in release v1.8.3 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant