Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow using MTX_QUERY inside source #3486

Merged
merged 1 commit into from
Jun 18, 2024
Merged

allow using MTX_QUERY inside source #3486

merged 1 commit into from
Jun 18, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jun 18, 2024

this allows to pass query parameters to sources, for instance:

source: rtsp://my_host/my_path?$MTX_QUERY
sourceOnDemand: true

Nightly release

https://github.com/bluenviron/mediamtx/actions/runs/9571463402

this allows to pass query parameters to sources, for instance:

source: rtsp://my_host/my_path?$MTX_QUERY
sourceOnDemand: true
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 76.78571% with 13 lines in your changes missing coverage. Please review.

Project coverage is 56.67%. Comparing base (dfa2e81) to head (04701b9).

Files Patch % Lines
internal/core/static_source_handler.go 70.00% 12 Missing ⚠️
internal/core/path.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3486      +/-   ##
==========================================
+ Coverage   56.65%   56.67%   +0.01%     
==========================================
  Files         190      190              
  Lines       19146    19151       +5     
==========================================
+ Hits        10848    10853       +5     
  Misses       7470     7470              
  Partials      828      828              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 65d90f7 into main Jun 18, 2024
8 checks passed
@aler9 aler9 deleted the feature/mtx-query branch June 18, 2024 20:10
Copy link
Contributor

github-actions bot commented Jul 7, 2024

This issue is mentioned in release v1.8.4 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant