Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boot fix stage 2 #2537

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Williangalvani
Copy link
Member

This tests our install.sh scripts against blueos_startup_update to ensure the current code state will never require a subsequent reboot after blueos_startup_update

@Williangalvani
Copy link
Member Author

@patrickelectric @joaoantoniocardoso this is what I had in mind for making sure our install scripts match our blueos_startup_update. I am open for suggestions and/or better alternatives.

One thing I'm worried about is that our startup.json.default should always match what is actually in blueos. so I don't think it should be manipulated by blueos_startup_update during the first boot.

@Williangalvani
Copy link
Member Author

this is the actual test part

@joaoantoniocardoso
Copy link
Member

I think this idea works, as it contemplates the requirements for the config file:

  • allow users to customize
  • protect our configuration from users' change
  • keep up-to-date

I think the next thing we should do is to generate the file in the tree as a git pre-commit client-side hook that runs whenever the script changes.

@Williangalvani Williangalvani force-pushed the boot_fix_stage_2 branch 2 times, most recently from 9e862da to a76dc72 Compare April 15, 2024 18:29
@Williangalvani Williangalvani force-pushed the boot_fix_stage_2 branch 2 times, most recently from 34abbbc to b4ddc56 Compare April 23, 2024 16:46
@Williangalvani
Copy link
Member Author

@joaoantoniocardoso @JoaoMario109 @patrickelectric how do you guys feel about this?
I personally don't like it but I think it is helpful...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants