Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: services: beacon: fix broken ethernet domain name config #2549

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core/services/beacon/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,12 @@ def set_hostname(self, hostname: str) -> None:
for interface in self.manager.settings.interfaces:
match InterfaceType.guess_from_name(interface.name):
case InterfaceType.WIRED | InterfaceType.USB:
interface.domain_names = [hostname, self.DEFAULT_HOSTNAME] # let's keep our default just in case
interface.domain_names = [
old_name.replace(self.DEFAULT_HOSTNAME, hostname) for old_name in interface.domain_names
]
# Let's keep our default just in case
if self.DEFAULT_HOSTNAME not in interface.domain_names:
interface.domain_names.append(self.DEFAULT_HOSTNAME)
case InterfaceType.WIFI:
interface.domain_names = [f"{hostname}-wifi"]
case InterfaceType.HOTSPOT:
Expand Down
Loading