CI: mypy: Fix missing stubs for third-party libs #315
Conversation
|
I don't have a clue on what's happening. This is the recommended argument. It's also giving segfault on my computer. Directly installing types-requests is a option, but I want to avoid it so we don't need to maintain it for every single lib. Tracking here. |
|
Ok, wheels are broken. |
|
New problem: |
rafaellehmkuhl
force-pushed
the
fix-mypy-stubs
branch
from
ec59131
to
3818bec
Compare
rafaellehmkuhl
changed the title
--install-types argument to fix missing stubs
| @@ -31,6 +31,9 @@ jobs: | |||
| pip install pyfakefs pytest-cov pytest-timeout pylint mypy isort black asyncmock | |||
| find . -type f -name "setup.py" | xargs --max-lines=1 --replace=% python % install --user | |||
|
|
|||
| # Install necessary typesheds for mypy tests | |||
| pip install types-requests | |||
There was a problem hiding this comment.
It feels that such package should be in the setup.py and not here..
Otherwise we are going to loose track in where the packages come from and if we are still using it.
@Williangalvani what you think ?
There was a problem hiding this comment.
We can introduce a extra_require section on the setup.py.
extras_require={
'dev': [
'types_requests'
]
}
There was a problem hiding this comment.
I'm ok with the original solution.
Having it as a dev dependecy sounds nice, but then we need to install each service in this script
rafaellehmkuhl
force-pushed
the
fix-mypy-stubs
branch
8 times, most recently
from
2cb7abf
to
5d30ad8
Compare
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
rafaellehmkuhl
force-pushed
the
fix-mypy-stubs
branch
from
5d30ad8
to
7c88a35
Compare
|
Closed in favor of #316 |
Mypy doesn't install stubs for third-party libraries anymore by default, like explained on the following article:
https://mypy-lang.blogspot.com/2021/05/the-upcoming-switch-to-modular-typeshed.html
Fix #315