Get rid of platform.py. #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydenroche5
force-pushed
the
platform_refactor
branch
from
546a0fd to
2e2f8b3
Compare
I added this recently so we could tuck away platform detection logic in its own file. Upon further reflection, this really isn't helping us much at this stage. The information we need is already in a pretty usable form via the `sys` module.
haydenroche5
force-pushed
the
platform_refactor
branch
from
2e2f8b3 to
c6a7195
Compare
m-mcgowan
approved these changes
Jul 18, 2023
Contributor
m-mcgowan
left a comment
m-mcgowan
left a comment
There was a problem hiding this comment.
LGTM. The primary concern I have with all the global state around platforms is that it makes unit testing much harder. However, fixing that is a bigger lift, so happy to punt until the pain of testing becomes too much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this recently so we could tuck away platform detection logic in its own file. Upon further reflection, this really isn't helping us much at this stage. The information we need is already in a pretty usable form via the
sysmodule.