Refactor fluent API unit tests. #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The so-called fluent API unit tests are intermingled with the notecard.py tests in test_notecard.py. This commit separates these tests out into their own individual test files, corresponding to their respective modules (e.g. the methods in card.py are tested by test_card.py). This commit also adds a conftest.py that defines fixtures for testing the fluent APIs, since they all follow a very similar pattern. Specifically, these fixtures test that - The fluent API calls the Notecard API correctly. - The fluent API requires a valid Notecard object.
haydenroche5
force-pushed
the
fluent_api_test_refactor
branch
from
f4e08a8 to
faa8d0c
Compare
Collaborator
Author
|
@bsatrom I know coverage is ticking down with these recent PRs, but rest assured that I have more testing coming that will bring it back up. |
bsatrom
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The so-called fluent API unit tests are intermingled with the notecard.py tests in test_notecard.py. This commit separates these tests out into their own individual test files, corresponding to their respective modules (e.g. the methods in card.py are tested by test_card.py). This commit also adds a conftest.py that defines fixtures for testing the fluent APIs, since they all follow a very similar pattern. Specifically, these fixtures test that