When checking CRC, treat sequence number and CRC as integers. #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the hex strings for the CRC and sequence number from the Notecard were compared against hex strings computed by the host. If the casing of the hex digits differs between host and Notecard, there can be false CRC errors. Treating all values as integers gets rid of this problem.
bsatrom
approved these changes
Nov 19, 2023
bsatrom
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the hex strings for the CRC and sequence number from the Notecard were compared against hex strings computed by the host. If the casing of the hex digits differs between host and Notecard, there can be false CRC errors. Treating all values as integers gets rid of this problem.