Skip to content

Handle "not supported" errors in the core Transaction function. #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haydenroche5 merged 1 commit into from
Mar 13, 2024
Merged

Handle "not supported" errors in the core Transaction function. #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion notecard/notecard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ def Transaction(self, req, lock=True):
continue

if 'err' in rsp_json:
if '{io}' in rsp_json['err']:
if '{io}' in rsp_json['err'] and '{not-supported}' not in rsp_json['err']:
if self._debug:
print('Response has error field indicating ' + \
f'I/O error: {rsp_json}')
Expand Down
10 changes: 10 additions & 0 deletions test/test_notecard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,16 @@ def test_transaction_retries_on_io_error_in_response(
assert card._transact.call_count == \
notecard.CARD_TRANSACTION_RETRIES

def test_transaction_does_not_retry_on_not_supported_error_in_response(
self, arrange_transaction_test):
card = arrange_transaction_test()
req = {"req": "hub.status"}

with patch('notecard.notecard.json.loads',
return_value={'err': 'some error {io} {not-supported}'}):
card.Transaction(req)
assert card._transact.call_count == 1

def test_transaction_does_not_retry_on_bad_bin_error_in_response(
self, arrange_transaction_test):
card = arrange_transaction_test()
Expand Down