feat: add NTN (Non-Terrestrial Network) support #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Bucknalla
requested changes
Feb 11, 2025
Collaborator
Bucknalla
left a comment
Bucknalla
left a comment
There was a problem hiding this comment.
Please make these changes to card.transport instead, Devin.
notecard/card.py
Outdated
|
|
||
| @validate_card_object | ||
| def wireless(card, mode=None, apn=None): | ||
| def wireless(card, mode=None, apn=None, method=None): |
Collaborator
There was a problem hiding this comment.
This is the wrong API to add the NTN methods to, it should be card.transport. Take a look at https://dev.blues.io/api-reference/notecard-api/card-requests/latest/#card-transport for how to implement this.
Contributor
Author
|
Devin is currently unreachable - the session may have died. |
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
…ransport method Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
…uplicate method Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
…nd fix line length Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Collaborator
|
Closing in favour of #94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template System Improvements
This PR enhances the
note.templatefunctionality with improved validation, binary record support, and compact format features.Changes
Testing
Documentation
Link to Devin run: https://app.devin.ai/sessions/95ffd763d71b445198b9370e49dcd93f