Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exact matches always show profile regardless of block status #2653

Merged
merged 5 commits into from
Aug 16, 2024
Merged

exact matches always show profile regardless of block status #2653

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0318c04
exact matches always show profile regardless of block status
haileyok Jul 19, 2024
1f6c064
return false if no actor
haileyok Jul 19, 2024
587e6f6
Merge remote-tracking branch 'origin/main' into hailey/typeahead-exac…
haileyok Aug 5, 2024
b4c76d5
tweaks
haileyok Aug 5, 2024
4694299
update the duplicate test...
haileyok Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/bsky/src/api/app/bsky/actor/searchActorsTypeahead.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,14 @@ const hydration = async (
}

const noBlocks = (inputs: RulesFnInput<Context, Params, Skeleton>) => {
const { ctx, skeleton, hydration } = inputs
skeleton.dids = skeleton.dids.filter(
(did) => !ctx.views.viewerBlockExists(did, hydration),
)
const { ctx, skeleton, hydration, params } = inputs
skeleton.dids = skeleton.dids.filter((did) => {
// Always display exact matches so that users can find profiles that they have blocked
const isExactMatch =
hydration.actors?.get(did)?.handle?.toLowerCase() ===
params.q?.toLowerCase()
haileyok marked this conversation as resolved.
Show resolved Hide resolved
return isExactMatch || !ctx.views.viewerBlockExists(did, hydration)
})
return skeleton
}

Expand Down