Don't add unused keydown listeners #7218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
rm-open - social-app PR #7218
Render
Destroyed
gaearon
changed the title
arcalinea
temporarily deployed
to
rm-open - social-app PR #7218
Render
Destroyed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web-only.
We have hundreds of these listeners at any moment in time but usually they're not doing anything:
They're only relevant when
openistrue, as seen in the code of the handlers.So let's attach these listeners only if
openis true.Test Plan
Place
console.loginto the listeners. Verify they run on every keystroke across the app.Apply the fix.
Verify they no longer run.
Verify the hashtag link web dropdown menu still responds to "Escape".