Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of visual representation of the table representing catalog search results #121

Merged
merged 3 commits into from
Apr 2, 2021

Conversation

dmgav
Copy link
Contributor

@dmgav dmgav commented Apr 2, 2021

Description

Insignificant changed to the code that improve visual representation for catalog search results:

  • Changed column name Transient Scan ID to Scan ID: the cell value is unlikely to be more than 5 characters wide and is 1 or 2 characters wide in the example. The table looks much better if the column is narrower. There are 2 more instances of Transient Scan ID in the code, which could also be replaced by Scan ID for consistency if needed.

  • Change table settings to show grid, alternate row colors, make the last column extendable and column header titles left-aligned.

  • Use QSpacerItem to fill the space below the catalog name selector (QComboBox) when no catalog is selected.

  • Deselect catalog (clear catalog name from the combo box) after 'Back' button is pressed.

Motivation and Context

How Has This Been Tested?

@danielballan
Copy link
Member

The linting failed because black accidentally removed their stable branch, which broke our linting GitHub Action workflow (and many others). Looks like they plan to restore it, so we don't need to change anything about our workflow. psf/black#2079

Confirmed locally that black runs cleanly on this branch.

@danielballan danielballan merged commit 2f3dfa1 into bluesky:master Apr 2, 2021
@mrakitin
Copy link
Member

mrakitin commented Apr 6, 2021

@danielballan, is the local black from a release on PyPI? Would it make sense to pin to a specific version corresponding to that latest release? I understand there may be more work in the future to make sure we use the latest features, but in most cases, the local tests use the already installed version which also may be out-of-date.

Alternatively, black.yml may be reworked to look like flake8.yml. That way we would rely on the more "stable"/static releases on PyPI.

@dmgav
Copy link
Contributor Author

dmgav commented Apr 6, 2021

I think that it makes a lot of sense to rework black.yml to look like flake8.yml instead of relying on GH actions. Let me try how well it works.

@dmgav
Copy link
Contributor Author

dmgav commented Apr 6, 2021

I implemented changes in PR bluesky/bluesky-queueserver#147. The modified action seems to work fine: 'black' is downloaded from PyPI, action fails if 'black' is expected to change any of the files and succeeds otherwise.

@mrakitin
Copy link
Member

mrakitin commented Apr 6, 2021

I like that. Thanks, @dmgav!

@danielballan
Copy link
Member

I agree.

@dmgav dmgav deleted the better-table branch September 8, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants