Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: unit test fails #210

Closed
prjemian opened this issue Dec 5, 2021 · 2 comments · Fixed by #211
Closed

BUG: unit test fails #210

prjemian opened this issue Dec 5, 2021 · 2 comments · Fixed by #211
Assignees
@prjemian
Labels
bug
Milestone
1.0.2

Comments

@prjemian
Copy link
Contributor

prjemian commented Dec 5, 2021

The unit tests fail now when testing for the ("gobject-introspection", "1.68.0"), package.
@prjemian prjemian added the bug label Dec 5, 2021
@prjemian prjemian added this to the v1.1 milestone Dec 5, 2021
@prjemian prjemian self-assigned this Dec 5, 2021
prjemian added a commit that referenced this issue Dec 5, 2021
@prjemian
DOC #210 add diagnostic to workflow
dc745a1
@prjemian prjemian mentioned this issue Dec 5, 2021
Merged
prjemian added a commit that referenced this issue Dec 5, 2021
@prjemian
MNT #210 remove hidden workflow steps
b857ad8
prjemian added a commit that referenced this issue Dec 5, 2021
@prjemian
CI #210 typo
8f1f0e9
@prjemian
Copy link
Contributor Author

prjemian commented Dec 5, 2021

Tets fails because the gobject-introspection package is not installed. That requirement should have been inherited from the hkl package. Adding it here for now.

@prjemian
Copy link
Contributor Author

prjemian commented Dec 5, 2021

The publish-docs workflow is (should be) only run on pushes to the main branch:

hklpy/.github/workflows/publish-docs.yml

Lines 9 to 12 in 54defea

on:
push:
branches:
- main

The additional tests are a fail-safe trap for previously undetected problems.

prjemian added a commit that referenced this issue Dec 5, 2021
@prjemian
MNT #210 add required package
9937765
prjemian added a commit that referenced this issue Dec 5, 2021
@prjemian
CI #210 restore workflow steps
7c7af6d
@prjemian prjemian modified the milestones: v1.1, 1.0.2 Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prjemian prjemian

Labels
bug
Projects
None yet
Milestone
1.0.2
Development

Successfully merging a pull request may close this issue.

repair failing unit test bluesky/hklpy
1 participant
@prjemian