Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update versioneer #235

Closed
prjemian opened this issue Jun 22, 2022 · 3 comments · Fixed by #236
Closed

update versioneer #235

prjemian opened this issue Jun 22, 2022 · 3 comments · Fixed by #236
Assignees
Labels
Milestone

Comments

@prjemian
Copy link
Contributor

Confirm if updates to versioneer support is necessary. (Note similar PR bluesky/hkl-notebooks#4) with these remarks:

SafeConfigParser has been deprecated since Python 3.2 and will be removed in py312.

python/cpython#28292
https://bugs.python.org/issue45173
python/cpython#89336

Similar code exists now in hklpy:

parser = configparser.SafeConfigParser()

@prjemian prjemian added the task label Jun 22, 2022
@prjemian prjemian added this to the v1.1 milestone Jun 22, 2022
@prjemian prjemian self-assigned this Jun 22, 2022
@prjemian
Copy link
Contributor Author

prjemian commented Jun 22, 2022

See: Updating Versioneer

  • install the new Versioneer (pip install -U versioneer or equivalent)
  • edit setup.cfg, if necessary, to include any new configuration settings indicated by the release notes. See UPGRADING for details.
  • re-run versioneer install in your source tree, to replace SRC/_version.py
  • commit any changed files

@prjemian
Copy link
Contributor Author

(dev-hklpy) prjemian@zap:~/.../Bluesky/hklpy$ versioneer install 
replacing old versioneer.py (0.15)
versioneer.py (0.22) installed into local tree
Now running 'versioneer.py setup' to install the generated files..
 creating hkl/_version.py
 appending to hkl/__init__.py
 'versioneer.py' already in MANIFEST.in
 versionfile_source already in MANIFEST.in

prjemian added a commit that referenced this issue Jun 22, 2022
@prjemian
Copy link
Contributor Author

These changes include the principle change implemented in PR bluesky/hkl-notebooks#4:

    parser = configparser.ConfigParser()

This additional change remains to replace the two lines following:

    parser.read(setup_cfg)

prjemian added a commit that referenced this issue Jun 22, 2022
@prjemian prjemian modified the milestones: v1.2, v1.1 Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant