Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase precision of A_KEV constant #206

Merged
merged 6 commits into from
Sep 16, 2021
Merged

Increase precision of A_KEV constant #206

merged 6 commits into from
Sep 16, 2021

Conversation

prjemian
Copy link
Contributor

FIX #172, to match 2018 CODATA value.

@prjemian prjemian added this to the v1.0.1 milestone Sep 15, 2021
@prjemian prjemian self-assigned this Sep 15, 2021
@prjemian
Copy link
Contributor Author

@mrakitin Ready for review. I'm thinking of a 1.0.1 release next week. Maintenance (and maybe bug fix). Only a few changes.

Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think the sphinx separator may need to be updated (suggested below).

RELEASE_NOTES.rst Outdated Show resolved Hide resolved
@prjemian
Copy link
Contributor Author

prjemian commented Sep 16, 2021 via email

@mrakitin
Copy link
Member

Separator for the last column does not have too fill the full width. This is a restructured text rule.

Can it be shorter or longer? I remember we had to match the length of the heading with the length of the separators (see e.g. NSLS-II/scientific-python-cookiecutter#78).

@prjemian
Copy link
Contributor Author

prjemian commented Sep 16, 2021 via email

@prjemian
Copy link
Contributor Author

For example:

The rightmost column is unbounded; text may continue past the edge of the table (as indicated by the table borders). However, it is recommended that borders be made long enough to contain the entire text.

@prjemian
Copy link
Contributor Author

From this, I understand the width of the rightmost === border can be shorter than or equal to the width of the widest content row.

@prjemian
Copy link
Contributor Author

Hold it, though, that's for tables, this is a section heading, it must be equal to (or greater than) the content width of the row above it. I'll take your suggestion. Ack!

Co-authored-by: Maksim Rakitin <mrakitin@users.noreply.github.com>
@prjemian
Copy link
Contributor Author

That's the consequence of reading on a mobile phone.

@prjemian prjemian merged commit d7bf020 into main Sep 16, 2021
@prjemian prjemian deleted the 172-A_KEV-precision branch September 16, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A_KEV precision fails unit test
2 participants