-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase precision of A_KEV constant #206
Conversation
@mrakitin Ready for review. I'm thinking of a 1.0.1 release next week. Maintenance (and maybe bug fix). Only a few changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I think the sphinx separator may need to be updated (suggested below).
Separator for the last column does not have too fill the full width. This
is a restructured text rule.
…On Thu, Sep 16, 2021, 1:06 PM Maksim Rakitin ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good to me. I think the sphinx separator may need to be updated
(suggested below).
------------------------------
In RELEASE_NOTES.rst
<#206 (comment)>:
> +v1.0.1 (2021-09-20 or thereabouts)
+======================
⬇️ Suggested change
-v1.0.1 (2021-09-20 or thereabouts)
-======================
+v1.0.1 (2021-09-20 or thereabouts)
+==================================
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#206 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARMUMCZGW3WMUNRRQC6EJ3UCIW2TANCNFSM5EDDJ57Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Can it be shorter or longer? I remember we had to match the length of the heading with the length of the separators (see e.g. NSLS-II/scientific-python-cookiecutter#78). |
The last column is different than the others. It can be a different length
than the widest content row. Not sure what is there minimum, guessing it
might be at least 3.
…On Thu, Sep 16, 2021, 1:22 PM Maksim Rakitin ***@***.***> wrote:
Separator for the last column does not have too fill the full width. This
is a restructured text rule.
Can it be shorter or longer? I remember we had to match the length of the
heading with the length of the separators (see e.g.
NSLS-II/scientific-python-cookiecutter#78
<NSLS-II/scientific-python-cookiecutter#78>).
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#206 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARMUMFO763RTISDINV275LUCIYVXANCNFSM5EDDJ57Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
For example:
|
From this, I understand the width of the rightmost |
Hold it, though, that's for tables, this is a section heading, it must be equal to (or greater than) the content width of the row above it. I'll take your suggestion. Ack! |
Co-authored-by: Maksim Rakitin <mrakitin@users.noreply.github.com>
That's the consequence of reading on a mobile phone. |
FIX #172, to match 2018 CODATA value.