Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document the max_forward_iterations attribute #207

Merged
merged 2 commits into from
Sep 19, 2021
Merged

document the max_forward_iterations attribute #207

merged 2 commits into from
Sep 19, 2021

Conversation

prjemian
Copy link
Contributor

FIX #195

@prjemian prjemian added this to the v1.0.1 milestone Sep 15, 2021
@prjemian prjemian self-assigned this Sep 15, 2021
mrakitin
mrakitin reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this docstring may need a correction.

hkl/diffract.py Outdated Show resolved Hide resolved
@prjemian
Copy link
Contributor Author

@mrakitin Ready for review.

@prjemian prjemian merged commit 362bc40 into main Sep 19, 2021
@prjemian prjemian deleted the 195-max_forward_iterations branch September 19, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrakitin mrakitin mrakitin approved these changes

Assignees

@prjemian prjemian

Labels
documentation
Projects
None yet
Milestone
v1.0.1
Development

Successfully merging this pull request may close these issues.

max_forward_iterations not found in the online documentation
2 participants
@prjemian @mrakitin