Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand to py310 & py311 #261

Merged
merged 14 commits into from
Oct 6, 2023
Merged

expand to py310 & py311 #261

merged 14 commits into from
Oct 6, 2023

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Oct 4, 2023 •
edited
Loading

@prjemian prjemian added the task label Oct 4, 2023
@prjemian prjemian added this to the v1.0.4 milestone Oct 4, 2023
@prjemian prjemian self-assigned this Oct 4, 2023
@prjemian
Copy link
Contributor Author

prjemian commented Oct 4, 2023

bluesky.simulation.check_limits() was refactored and can't be used here since it errors with:

RuntimeError: Bluesky event loop not running

Need to refactor some tests.

@prjemian
Copy link
Contributor Author

prjemian commented Oct 4, 2023

Reducing workflow duplication in 0411e9f.

@prjemian
Copy link
Contributor Author

prjemian commented Oct 4, 2023

@mrakitin , @klauer : This is ready for review.

mrakitin
mrakitin approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @prjemian!

I made a few suggestions mostly regarding the CI/pre-commit. They can be addressed after the release.

.github/workflows/conda_unit_test.yml Show resolved Hide resolved
.github/workflows/conda_unit_test.yml Outdated Show resolved Hide resolved
.github/workflows/conda_unit_test.yml Outdated Show resolved Hide resolved
hkl/tests/test_util.py
@@ -63,7 +63,7 @@ def test_software_versions_default_list(case):
("hkl", "5.0.0"),
("hklpy", "0"), # minimum test for unversioned use
(NO_SUCH_PACKAGE_NAME, "---"),
("ophyd", "1.6"),
# ("ophyd", "1.6"), conda has right version but pip has 0.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evalott100, is it something that can be easily fixed in the pyproject.toml config for ophyd?

prjemian and others added 2 commits October 6, 2023 12:52
@prjemian @mrakitin
Update .github/workflows/conda_unit_test.yml
85815b1 
Co-authored-by: Max Rakitin <mrakitin@users.noreply.github.com>
@prjemian @mrakitin
Update .github/workflows/conda_unit_test.yml
47eaeb7 
Co-authored-by: Max Rakitin <mrakitin@users.noreply.github.com>
@prjemian prjemian mentioned this pull request Oct 6, 2023
Closed
@prjemian prjemian merged commit a7ddc35 into main Oct 6, 2023
6 checks passed
@prjemian prjemian deleted the 159-py310-and-py311 branch October 6, 2023 17:55
klauer
klauer reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@klauer klauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late review as I'm at a conference but this LGTM 👍

@prjemian prjemian added the hacktoberfest-accepted https://hacktoberfest.com/ label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klauer klauer klauer left review comments

@mrakitin mrakitin mrakitin approved these changes

Assignees

@prjemian prjemian

Labels
hacktoberfest-accepted https://hacktoberfest.com/ task
Projects
None yet
Milestone
v1.0.4
Development

Successfully merging this pull request may close these issues.

Expand support to include Py3.10 & 3.11
3 participants
@prjemian @klauer @mrakitin