add pre-commit checks #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prjemian
commented
Oct 17, 2023
prjemian
commented
- close linting checks can be done via pre-commit #263
In a separate issue, resolve issues noted when certain tests were commented out due to failure with existing code. |
Closed
mrakitin
reviewed
Oct 19, 2023
Comment on lines
+24
to
+37
| # - repo: https://github.com/pycqa/flake8 | ||
| # rev: 4.0.1 | ||
| # hooks: | ||
| # - id: flake8 | ||
|
|
||
| # - repo: https://github.com/timothycrosley/isort | ||
| # rev: 5.12.0 | ||
| # hooks: | ||
| # - id: isort | ||
|
|
||
| # - repo: https://github.com/psf/black | ||
| # rev: 22.8.0 | ||
| # hooks: | ||
| # - id: black |
There was a problem hiding this comment.
Did those commented-out checks fail?
Co-authored-by: Max Rakitin <mrakitin@users.noreply.github.com>
|
Yes, those checks failed as noted above. Figured that fixing then was not the job of this issue. |
mrakitin
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.