Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore_reflections() use renamed motor axes if so defined #273

Merged
merged 3 commits into from
Oct 19, 2023
Merged

restore_reflections() use renamed motor axes if so defined #273

merged 3 commits into from
Oct 19, 2023

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian added the bug label Oct 17, 2023
@prjemian prjemian added this to the v1.1 milestone Oct 17, 2023
@prjemian prjemian self-assigned this Oct 17, 2023
@prjemian prjemian added the hacktoberfest-accepted https://hacktoberfest.com/ label Oct 17, 2023
mrakitin
mrakitin approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good to me.

hkl/tests/test_util.py
def cat():
import databroker

yield databroker.temp().v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I typically do yield to perform some cleanup after that, but I think it's a good pattern in general.
https://docs.pytest.org/en/6.2.x/fixture.html has different approaches depending on the needs.

hkl/tests/test_util.py
a0 = 5.4321
# fmt: off
diffractometer.calc.new_sample(
"vibranium",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the material name! Good for tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You noticed! Who can dispute the crystal lattice, anyway?

@prjemian prjemian merged commit 299d39a into main Oct 19, 2023
6 checks passed
@prjemian prjemian deleted the 215-restore_reflections branch October 19, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrakitin mrakitin mrakitin approved these changes

Assignees

@prjemian prjemian

Labels
bug hacktoberfest-accepted https://hacktoberfest.com/
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

restore_reflections(orientation, fourc) cannot find renamed positioner
2 participants
@prjemian @mrakitin