-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid crash in add_reflections, add axes_(r,w,c) #309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have a chance to look at the tests yet. That might skew the comments I left. :)
Co-authored-by: Padraic Shafer <76011594+padraic-shafer@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you're planning to add more tests.
Noting here that the tests so far look reasonable.
@padraic-shafer : I hardened the validation process for namedtuples. Previously, an unacceptable namedtuple instance was handled by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest updates look good.
Although probably beyond what you have in mind for this PR, the extent and combination of validation tests suggest that hypothesis for property-based testing could be worthwhile in the long run. |
That looks like a good addition for the v2.0 release. For now, I'm trying to keep this v1.1.0 release limited to the new geometries and some user-requested features & bug fixes. This is the last planned minor (semver: major.minor.patch) release before v2. Since the changes for v2.0 are planned as a complete overhaul, this might be too much for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very detailed tests!
I spotted a couple of typos, it's good to go once fixed.
Co-authored-by: Max Rakitin <mrakitin@users.noreply.github.com>
Co-authored-by: Max Rakitin <mrakitin@users.noreply.github.com>
Co-authored-by: Max Rakitin <mrakitin@users.noreply.github.com>
@padraic-shafer @mrakitin : Thanks for the reviews! |
@jwkim-anl : Thanks for the bug report!