Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Path Signals #122

Closed
callumforrester opened this issue Feb 23, 2024 · 4 comments
Closed

Consider Path Signals #122

callumforrester opened this issue Feb 23, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers hackathon Good issues for the upcoming bluesky hackathon

Comments

@callumforrester
Copy link
Contributor

Some string PVs are intended only to store file paths, e.g. the HDF5 plugin write path. Perhaps there is value in representing these with a Signal[Path] rather than a Signal[str] and performing some validation on input values.

See ophyd_async.epics.areadetector.writers.nd_file_hdf.NDFileHDF for an example.

@coretl any thoughts?

@DominicOram
Copy link
Contributor

👍 from me

@coretl
Copy link
Collaborator

coretl commented Feb 26, 2024

Could be done, but I'd say this is low priority compared with the other things we're doing

@callumforrester
Copy link
Contributor Author

Will leave it as a good first issue then

@stan-dot stan-dot self-assigned this Mar 14, 2024
@stan-dot stan-dot removed their assignment Apr 3, 2024
@CoePaul CoePaul added the hackathon Good issues for the upcoming bluesky hackathon label Apr 17, 2024
@CoePaul CoePaul moved this to Todo in Hackathon 2024 Apr 17, 2024
@CoePaul CoePaul self-assigned this Apr 17, 2024
@CoePaul CoePaul moved this from Todo to In Progress in Hackathon 2024 Apr 17, 2024
@CoePaul CoePaul moved this from In Progress to Todo in Hackathon 2024 Apr 20, 2024
@CoePaul CoePaul removed their assignment Apr 20, 2024
@subinsaji subinsaji assigned subinsaji and unassigned subinsaji Jul 19, 2024
@coretl
Copy link
Collaborator

coretl commented Jul 22, 2024

Closing as PathProvider makes the above usecase less compelling. We can revisit after 1.0 if this is still needed

@coretl coretl closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hackathon Good issues for the upcoming bluesky hackathon
Projects
No open projects
Status: Todo
Development

No branches or pull requests

6 participants