Fix root/path kwargs for Stream Resource documents generated by HDFWriter #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing? |
|
This change is good, I will finish it |
DiamondJoseph
force-pushed
the
fix-sr-paths
branch
6 times, most recently
from
800aad8 to
6979321
Compare
DiamondJoseph
force-pushed
the
fix-sr-paths
branch
from
6979321 to
5c6f95f
Compare
evalott100
approved these changes
Feb 22, 2024
callumforrester
approved these changes
Feb 23, 2024
| directory_path: str | ||
| filename_prefix: str | ||
| """ | ||
| Information about where and how to write a file. |
There was a problem hiding this comment.
If you can come up with a sufficiently brief explanation of why both root and resource_dir are needed, I think it would be useful to put in this docstring. Maybe something like
The bluesky event model splits the URI for a resource into two segments to aid in different applications mounting filesystems at different mount points.
| @@ -45,15 +45,15 @@ async def open(self, multiplier: int = 1) -> Dict[str, Descriptor]: | |||
| self.hdf.num_extra_dims.set(0), | |||
| self.hdf.lazy_open.set(True), | |||
| self.hdf.swmr_mode.set(True), | |||
| self.hdf.file_path.set(info.directory_path), | |||
| self.hdf.file_name.set(f"{info.filename_prefix}{self.hdf.name}"), | |||
| self.hdf.file_path.set(str(info.root / info.resource_dir)), | |||
DiamondJoseph
force-pushed
the
fix-sr-paths
branch
from
51bbc1e to
01ffb10
Compare
DiamondJoseph
force-pushed
the
fix-sr-paths
branch
from
01ffb10 to
7831498
Compare
DiamondJoseph
force-pushed
the
fix-sr-paths
branch
from
7831498 to
62a42e3
Compare
coretl
reviewed
Feb 28, 2024
coretl
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, root was hardcoded to '/'. This removes that, and instead ensures the root and resource_path are accurate.