Add support for bluesky Suspenders #619
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #508
In a draft form, uploading for demonstration.
I've tried to copy the test https://github.com/bluesky/bluesky/blob/3bce96b85558993499174be7eebcd09f270a9271/src/bluesky/tests/test_suspenders.py#L25 here for ophyd-async, I'm not sure the best way to approach it. The test I've added is currently broken.
Some work needs to be done to figure out how to provoke the suspension while running the plan, as call_in_bluesky_event_loop will finish the task synchronously before running the plan, but I have observed that when the Suspender is called inside the bluesky event loop that the suspend event never gets made, as this call_soon_threadsafe call times out https://github.com/bluesky/bluesky/blob/39da716adfc4028baa4575b3922e7194ca734544/src/bluesky/suspenders.py#L169
Relies on bluesky/bluesky#1806