Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.12 to CI now that p4p is updated #655

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Add Python 3.12 to CI now that p4p is updated #655

merged 5 commits into from
Dec 4, 2024

Conversation

OCopping
Copy link
Contributor

@OCopping OCopping commented Nov 19, 2024 •
edited
Loading

I noticed Python 3.12 never got added to the CI after support for it in p4p got released.

@OCopping OCopping changed the title Re-add Python 3.12 to CI now that p4p is updated Add Python 3.12 to CI now that p4p is updated Nov 19, 2024
DiamondJoseph
DiamondJoseph requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're supporting 3.12 add it to the pyproject.toml too
Good work getting this over the line 🥳

@OCopping
Copy link
Contributor Author

The tests are failing because of a get_event_loop() deprecation warning/error.
From the docs:
Deprecated since version 3.12: Deprecation warning is emitted if there is no current event loop. In some future Python release this will become an error.

@OCopping OCopping force-pushed the re-add-python-3.12-ci branch from 742b980 to 743cdb2 Compare November 19, 2024 13:15
@coretl
Copy link
Collaborator

coretl commented Nov 19, 2024

The tests are failing because of a get_event_loop() deprecation warning/error. From the docs: Deprecated since version 3.12: Deprecation warning is emitted if there is no current event loop. In some future Python release this will become an error.

@evalott100 I think this is coming from the "detect pending tasks" fixture, would you mind taking a look please?

@OCopping OCopping force-pushed the re-add-python-3.12-ci branch 2 times, most recently from 3a3db72 to b6c2cda Compare November 19, 2024 13:55
@coretl coretl mentioned this pull request Nov 22, 2024
Open
@evalott100 evalott100 self-assigned this Nov 27, 2024
@evalott100
Copy link
Contributor

Taking this over.

@evalott100 evalott100 force-pushed the re-add-python-3.12-ci branch 2 times, most recently from 5e4ffd0 to 338e5cc Compare November 27, 2024 16:28
@evalott100 evalott100 mentioned this pull request Nov 27, 2024
Open
@evalott100 evalott100 force-pushed the re-add-python-3.12-ci branch from 66ae060 to 5837a68 Compare November 27, 2024 16:53
evalott100
evalott100 reviewed Nov 27, 2024
View reviewed changes
tests/core/test_readable.py Show resolved Hide resolved
tests/epics/adcore/test_drivers.py Outdated Show resolved Hide resolved
tests/sim/demo/test_sim_motor.py Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
DiamondJoseph
DiamondJoseph approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, but as I'm not as involved in ophyd-async consider this advisory only

panda_connect.py Outdated Show resolved Hide resolved
panda_connect.py Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
@evalott100 evalott100 force-pushed the re-add-python-3.12-ci branch 2 times, most recently from e68a173 to ad985e7 Compare November 28, 2024 11:33
@evalott100 evalott100 force-pushed the re-add-python-3.12-ci branch from ad985e7 to 16b4a7b Compare December 4, 2024 12:40
@evalott100 evalott100 force-pushed the re-add-python-3.12-ci branch from 16b4a7b to 5bd28db Compare December 4, 2024 12:40
@evalott100
Copy link
Contributor

@DiamondJoseph Tango supporting 3.12 is a much larger issue. For now we should skip it. #681

@evalott100 evalott100 force-pushed the re-add-python-3.12-ci branch from 5bd28db to 44fdf00 Compare December 4, 2024 14:35
@evalott100 evalott100 requested a review from coretl December 4, 2024 14:36
@evalott100 evalott100 merged commit 4ee4eb1 into main Dec 4, 2024
22 checks passed
@evalott100 evalott100 deleted the re-add-python-3.12-ci branch December 4, 2024 15:01
@evalott100 evalott100 restored the re-add-python-3.12-ci branch December 5, 2024 08:47
evalott100 added a commit that referenced this pull request Dec 5, 2024
@evalott100
Revert "Add Python 3.12 to CI now that p4p is updated (#655)"
c38f84c 
This reverts commit 4ee4eb1.
@evalott100 evalott100 deleted the re-add-python-3.12-ci branch December 5, 2024 08:52
@evalott100 evalott100 mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coretl coretl coretl left review comments

@evalott100 evalott100 evalott100 left review comments

@DiamondJoseph DiamondJoseph Awaiting requested review from DiamondJoseph

Assignees

@evalott100 evalott100

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OCopping @coretl @evalott100 @DiamondJoseph