copy workflows from blueapi, [still need to configure env values -not a code change] #664
Conversation
stan-dot
added
enhancement
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
stan-dot
force-pushed
the
662-add-codeql-and-sonarcloud-steps-to-the-ci
branch
from
8562d66 to
5f9ea2e
Compare
stan-dot
force-pushed
the
662-add-codeql-and-sonarcloud-steps-to-the-ci
branch
from
959cad1 to
cfe48a3
Compare
|
thanks for the comments @coretl . I deleted the 'if swift language' branches, kept the comments though to keep this more similar to the template workflow for codeql. now sure fully about the syntax in the periodic file though |
stan-dot
force-pushed
the
662-add-codeql-and-sonarcloud-steps-to-the-ci
branch
from
2a1df5b to
ff9f5e4
Compare
|
deleted outdated comments |
.github/workflows/_codeql.yaml
Outdated
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - language: python | ||
| build-mode: none |
There was a problem hiding this comment.
Redundant code
| strategy: | |
| fail-fast: false | |
| matrix: | |
| include: | |
| - language: python | |
| build-mode: none |
There was a problem hiding this comment.
why is it redundant? the default ci.yml did use the reference to that
There was a problem hiding this comment.
You make a matrix with precisely one entry in it, saying that all jobs in the matrix should complete if one fails, defining the variables language and build mode. You don't use those variables anywhere. If you delete this block of code then the workflow will do exactly the same.
.github/workflows/_codeql.yaml
Outdated
| permissions: | ||
| # required for all workflows | ||
| security-events: write | ||
|
|
||
| # required to fetch internal or private CodeQL packs | ||
| packages: read | ||
|
|
||
| # only required for workflows in private repositories | ||
| actions: read | ||
| contents: read |
There was a problem hiding this comment.
I suspect these permissions need to be in periodic.yml rather than here. Please add them one at a time and test using https://github.com/bluesky/ophyd-async/actions/workflows/periodic.yml until it is working.
stan-dot
force-pushed
the
662-add-codeql-and-sonarcloud-steps-to-the-ci
branch
from
ff9f5e4 to
5bcd8a8
Compare
stan-dot
force-pushed
the
662-add-codeql-and-sonarcloud-steps-to-the-ci
branch
from
6d4a8ec to
999ec8c
Compare
|
@coretl I think all is clear now |
@