-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster tango tests #684
base: main
Are you sure you want to change the base?
Faster tango tests #684
Conversation
remove unnecessary sleep from test, fix f string formatting
As part of this, can we change from using Lines 240 to 245 in 629e764
to putting an explicit |
Yep I like this, potentially makes it easier to unfork specific tests (though currently don't think there are any that can be). |
I'm having much difficulty trying to adjust tango tests to work in 3.12. I'll wait for this to be merged before I continue trying. |
Looks like tests are broken on main for me right now, are you seeing that? |
They're broken on main if using 3.12, but they work for me on the other versions? EditAh nevermind, it's happening on main too... After playing around with it for ages I'm thinking it's best to solve this first: The error is very elusive. |
Closing #667
Primarily reduces the number of tests by moving parametrized parameters inside the test -> reduces the total number of forks. Am investigating if it's possible to fork after the fixtures are loaded in case we want to retain the nice logging that prints pass/fail per parametrized test.
Also some small QOL changes, using a dataclass to make looping over ATTRIBUTES_SET nicer