Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError in ScalerCH.select_channels(None) #714

Closed
prjemian opened this issue Apr 30, 2019 · 9 comments
Closed

TypeError in ScalerCH.select_channels(None) #714

prjemian opened this issue Apr 30, 2019 · 9 comments

Comments

@prjemian
Copy link
Contributor

Seems that the code committed as part of #692 did not make it into tag 1.3.2, thus my local code expecting this fix fails like this:

~/.ipython/profile_bluesky/startup/20-detectors.py in <module>()
      4 
      5 scaler = ScalerCH('vm7:scaler1', name='scaler')
----> 6 scaler.select_channels(None)
      7 

~/Apps/anaconda/envs/bluesky/lib/python3.6/site-packages/ophyd/scaler.py in select_channels(self, chan_names)
    136 
    137         read_attrs = ['chan01']  # always include time
--> 138         for ch in chan_names:
    139             try:
    140                 read_attrs.append(name_map[ch])

TypeError: 'NoneType' object is not iterable

The fix does exist in the master branch now. Can a new tag be made in the next week?

prjemian added a commit to prjemian/ipython-vm7 that referenced this issue Apr 30, 2019
@prjemian
Copy link
Contributor Author

Example local workaround until the new tag.

@danielballan
Copy link
Member

Thanks for sharing the workaround. We could at least tag a beta this week. @klauer Are there still known problems with signals / callback-processing in master that should give us pause before tagging a new stable release?

@klauer
Copy link
Member

klauer commented Apr 30, 2019

Yes, this needs resolving: #708

We're looking to a new pyepics release soon, but there is not yet a fix designed for this issue. It likely will cause issues with PV reusage during a session. As far as I am aware, the refactor has not been extensively tested outside of CI.

@tacaswell
Copy link
Contributor

Ah, when I did the backports I looked at merged PRs, it looks like that commit got pushed directly to master so I missed it.

As @klauer points out master currently needs a bit more work before it can be tagged (and has some pretty big improvements (but given the rules of un-intended consequences means will also break something 😞 ) ).

Unless someone protests I'll cherry-pick that commit back to 1.3.x and tag 1.3.3 this afternoon?

@mrakitin
Copy link
Member

That's a good plan, @tacaswell.

@danielballan
Copy link
Member

Done and released on PyPI. Conda packages in progress.

@prjemian
Copy link
Contributor Author

prjemian commented May 2, 2019

Thanks! Conda package coming or I switch to pip on this as proof-of-fix?

@prjemian
Copy link
Contributor Author

prjemian commented May 2, 2019

I'm blind.

@mrakitin
Copy link
Member

mrakitin commented May 2, 2019

New conda packages are available at https://anaconda.org/lightsource2-tag/ophyd/files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants