Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarified source of an error message #1086

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

clarified source of an error message #1086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ophyd/signal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2056,7 +2056,7 @@ def put(
use_complete = self._put_complete

if not self.write_access:
raise ReadOnlyError("No write access to underlying EPICS PV")
raise ReadOnlyError(f"No write access to underlying EPICS PV : {self.name}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an EPICS signal, can you also add the write_pvname to the message? It's one of the diagnostics our instrument teams want to see in such a message.

Copy link
Contributor

@prjemian prjemian Jan 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the message would be helped by putting the write PV name first as stated.


self.control_layer_log.debug(
"_write_pv.put(value=%s, use_complete=%s, callback=%s, kwargs=%s)",
Expand Down