Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed search error in the documentation frontend #553

Conversation

jmaruland
Copy link
Collaborator

This PR solve a search error in the documentation frontend, where any time a query was requested from the search bar, the website stayed hanging and never showed the results; it showed the searching message indefinitely and the error message in the browser was "Uncaught ReferenceError: jQuery is not defined".

@padraic-shafer
Copy link
Contributor

@jmaruland Confirming that building the docs with your change worked for me locally.

Adding this link for posterity, in case we wonder 2-years later why this configuration setting is present. :-)

@jmaruland
Copy link
Collaborator Author

jmaruland commented Aug 21, 2023

@padraic-shafer I noticed this issue a couple of weeks ago and I thought at the moment that the problem was with my browser and it's cache probably.
It actually caught my attention last week, when I noticed the same problem with the bluesky documentation. That being said, the same issue is currently present in the bluesky documentation and probably, in other documentation sites under blueskyproject.io.

@danielballan danielballan merged commit 43030d5 into bluesky:main Aug 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants