-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zarr v2 endpoints to Tiled #774
Open
genematx
wants to merge
54
commits into
bluesky:main
Choose a base branch
from
genematx:add-zarr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 51 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
ac1e632
add zarr route
genematx dab92e3
ENH: basic zarr functionality
genematx b7e39a6
ENH: map tiled chunks to zarr blocks
genematx 784f391
MNT: Clean-up comments
genematx 08f255d
ENH: support tables
genematx d10e2f1
add zarr route
genematx 5b9e786
ENH: basic zarr functionality
genematx 198e24b
ENH: map tiled chunks to zarr blocks
genematx 9264d8e
MNT: Clean-up comments
genematx 2da31d3
ENH: support tables
genematx 09d6808
ENH: Add data type to sparse
genematx 2ed822f
resolve conflict
genematx 35cf1a8
ENH: support units for numpy datetime types
genematx a31bd94
MNT: removed unnecessary imports
genematx b36c6b4
ENH: add default value for units
genematx 260e83e
ENH: update BuiltinDtype in pydantic
genematx 0631288
ENH: update BuiltinDtype in pydantic
genematx 4ffa2bf
ENH: add default value for units
genematx 917319d
TST: datetime dtypes in test_array
genematx 91f0f98
MNT: Update changelog
genematx b6bef55
resolve conflict
genematx 00d0f5f
Clean-up
genematx ee0d2cc
MNT: gitignore alembic.ini
genematx 24faf6f
Merge branch 'main' into add-zarr
genematx e68e0e5
FIX: typo in comment
genematx 99cd7fc
ENH: Add data type to sparse
genematx 1fbb021
FIX: assignment error
genematx 1ec2425
MNT: clean and lint
genematx 808ebcb
MNT: update changelog
genematx 2e06e9f
Merge branch 'sparse-dtype' into add-zarr
genematx 88262c3
Merge branch 'main' into datetime-units
genematx 66eabcf
MNT: fix changelog
genematx 57137b1
FIX: tests with COOStructure
genematx a435b71
Merge branch 'sparse-dtype' into add-zarr
genematx 7e3c59a
Merge branch 'datetime-units' into add-zarr
genematx 527dad6
FIX: typing
genematx 4801407
BLD: add aiohttp package to server requirements
genematx 8a7c510
MNT: clean and lint
genematx 484c6a0
FIX: default value of units to empty string.
genematx c9fa03e
FIX: use None as the sentinel for the units kwarg
genematx 045969f
ENH: use np.datetime_data to extract units
genematx a742bd9
TST: Fix failing authorization test -- empty password
genematx 73b2b40
MNT: format and lint
genematx 15a2494
Merge branch 'datetime-units' into add-zarr
genematx e2e315f
Merge branch 'main' into add-zarr
genematx 24c86d5
MNT: remove deprecated PatchedStreamingResponse
genematx 4ace292
MNT: lint
genematx 9fd4d35
TST: add authentication tests
genematx 8335136
FIX: ensure support for py3.8
genematx fc2a4ce
MNT: lint
genematx 9c5388b
MNT: add changelog entry
genematx 851c155
MNT: moved aiohttp from required to dev dependencies
genematx 4afd5e4
TST: refactor ThreadedServer class for tests
genematx 202f10e
TST: test no writing in read-only mode
genematx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,6 +58,7 @@ config.yml | |
prometheus_data | ||
grafana_data | ||
data | ||
alembic.ini | ||
|
||
tiled/_version.py | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot find where this is used. Maybe this was needed in some transient state of the PR but no longer is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moreover, since we use
starlette
for the server andhttpx
for the client, it would be somewhat odd and redundant to useaiohttp
as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used by
fsspec.implementations.http.HTTPFileSystem
, which is needed to connect to a tiled server that requires authentication. I had the same thought yesterday, that this was something I used before but no longer need, but unfortunately it's not the case. We don't need it in all requirements though (only for testing), which I have fixed now.