-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use last policy #829
base: main
Are you sure you want to change the base?
Use last policy #829
Conversation
I think the last piece we need here is a new test that uses a mock access policy which fetches metadata from the node (the |
...Just to state it plainly: that will validate this design and make it much easier to reproduce any future issues with this. |
Next we want an example access policy that makes use of For example, what if some node was structured like:
Perhaps, based on the metadata in those items, the AccessPolicy would confer some data processing pipeline |
I'm not sure that's the best use case I can come up with. Maybe we should think a little more about this and get crisper use cases. But it seems important for |
Checklist
In ref of #814 - though implementation was adjusted to preserve existing behavior (i.e. subtrees can have differing access policies, still). This fixes an issue where the intended access policy as defined for a tree in a Tiled config is not properly applied to resources that are children in that tree, since the children themselves did not explicitly have an access policy attribute.
The behavior is now:
None
)filters
andalllowed_scopes
now also takes apath_parts
parameter which should be the list of segments from the current node until the target resource - in case the access policy needs this information to perform an access check (such as pulling information from a database).