Fix critical bug in delete_tree #835
Open
+26
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
delete_tree
deletes nodes recursively. It was added specifically to supporttiled serve directory --watch ...
, which blows and rebuilds the database when files change (as an initial simple/safe implementation).Crucially, it can only ever delete registered data, never user-uploaded data. Which is a good thing because, as implemented, it always deletes the entire tree---not from a prescribed node downward but always from the root. Bad bug!
This bug was masking other bugs, also fixed here. Needs tests, but here's a demo of the intended behavior working as planned on this PR branch:
Checklist