Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warnings/Add support for python 3.10 #94

Merged
merged 4 commits into from
Aug 27, 2022

Conversation

ziloka
Copy link

@ziloka ziloka commented Aug 23, 2022

Result
image

I'm not entirely sure how to remove the other deprecation warnings.
DeprecationWarning: Using ioctl() method
asyncio DatagramProtocol stops calling callbacks after OSError

Related to:
#89

@ziloka
Copy link
Author

ziloka commented Aug 23, 2022

the cli_helper function is there because asyncio event loop, run until complete function wants a coroutine. I followed this stackoverflow answer https://stackoverflow.com/questions/70303895/python-3-10-asyncio-gather-shows-deprecationwarning-there-is-no-current-event.

I'm no python expert so take my advice (and code) with a grain of salt

@ziloka ziloka changed the title Fix warnings for python3.10 Fix deprecation warnings for python 3.10 Aug 23, 2022
@bluet
Copy link
Owner

bluet commented Aug 23, 2022

Hi @ziloka could you remove the redundant commented-out codes?

You can use comments as notes to describe something or FIXME, but not just as a recycle bin to keep old code. Thanks! :-)

@ziloka
Copy link
Author

ziloka commented Aug 23, 2022

Got it

@bluet
Copy link
Owner

bluet commented Aug 24, 2022

@ziloka can you sync from master or rebase?

@ziloka
Copy link
Author

ziloka commented Aug 24, 2022

I synced with master

@vincentinttsh
Copy link
Collaborator

https://github.com/bluet/proxybroker2/runs/7994487659?check_suite_focus=true#step:9:105
It seen that still get DeprecationWarning in diffent file

@ziloka
Copy link
Author

ziloka commented Aug 26, 2022

Okay, thanks for letting me know

@ziloka ziloka changed the title Fix deprecation warnings for python 3.10 Remove deprecation warnings/Add support for python 3.10 Aug 26, 2022
@ziloka ziloka marked this pull request as draft August 26, 2022 01:42
@ziloka ziloka marked this pull request as ready for review August 26, 2022 03:04
@bluet
Copy link
Owner

bluet commented Aug 26, 2022

@ziloka Thanks for the fix.

Looks like there are still few DeprecationWarning: There is no current event loop in "All checks have passed" > "build & test / build (3.8, 1.1.14) (pull request)" > "Details" > "Test with pytest". Will you be able to solve them?

Ref:

@ziloka
Copy link
Author

ziloka commented Aug 27, 2022

Uh sorry i can't reproduce it
image

@sonarcloud
Copy link

sonarcloud bot commented Aug 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bluet
Copy link
Owner

bluet commented Aug 27, 2022

@ziloka that's weird. I can still see those deprecation warnings in tests.

I'll merge it anyway but we might need to do some follow-ups.

@bluet bluet merged commit 5151cd2 into bluet:master Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants