-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecation warnings/Add support for python 3.10 #94
Conversation
the cli_helper function is there because asyncio event loop, run until complete function wants a coroutine. I followed this stackoverflow answer https://stackoverflow.com/questions/70303895/python-3-10-asyncio-gather-shows-deprecationwarning-there-is-no-current-event. I'm no python expert so take my advice (and code) with a grain of salt |
Hi @ziloka could you remove the redundant commented-out codes? You can use comments as notes to describe something or FIXME, but not just as a recycle bin to keep old code. Thanks! :-) |
Got it |
@ziloka can you sync from master or rebase? |
I synced with master |
https://github.com/bluet/proxybroker2/runs/7994487659?check_suite_focus=true#step:9:105 |
Okay, thanks for letting me know |
@ziloka Thanks for the fix. Looks like there are still few Ref: |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@ziloka that's weird. I can still see those deprecation warnings in tests. I'll merge it anyway but we might need to do some follow-ups. |
Result
I'm not entirely sure how to remove the other deprecation warnings.
DeprecationWarning: Using ioctl() method
asyncio DatagramProtocol stops calling callbacks after OSError
Related to:
#89