Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS monitors show HTTP on the table #1626

Closed
gorkem-bwl opened this issue Jan 24, 2025 · 6 comments
Closed

HTTPS monitors show HTTP on the table #1626

gorkem-bwl opened this issue Jan 24, 2025 · 6 comments
Assignees
Labels
design Design related good first issue Good for newcomers
Milestone

Comments

@gorkem-bwl
Copy link
Contributor

When I create an HTTPS monitor, it shows as HTTP in the table.

Image
@gorkem-bwl gorkem-bwl added design Design related good first issue Good for newcomers labels Jan 24, 2025
@gorkem-bwl gorkem-bwl added this to the 2.1 milestone Jan 24, 2025
@Br0wnHammer
Copy link
Contributor

Can I take this issue on?

@gorkem-bwl
Copy link
Contributor Author

Sure, go ahead please. Installation instructions for Checkmate is on https://bluewavelabs.gitbook.io/checkmate

@ajhollid
Copy link
Collaborator

ajhollid commented Jan 24, 2025

This isn't a bug per se, this was a design decision.

The type here should probably be "Uptime"

There isn't really an "http" or "https" type of monitor.

We have the following monitor types:

  1. Uptime
  • HTTP
  • Ping
  • Docker
  • Port
  1. Pagespeed
  2. Infrastructure
  3. Distributed

@Br0wnHammer
Copy link
Contributor

@ajhollid Thank you for the feedback. You make a good point - if this isn't a bug, but rather a design decision. So, should I update the monitor type accordingly? Please let me know if I need to keep anything else in mind.

@ajhollid
Copy link
Collaborator

I think @gorkem-bwl can make the call here, we could do http(s)?

The idea we want to convey here is these monitors are performing checks via http protocol.

Other option is to parse the protocol out of the URL to figure out if it is http or https.

@gorkem-bwl
Copy link
Contributor Author

Yep, let's do that way - http(s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design related good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants