Fix lineno offset in show_skipped

The line number is 0-based here, so add 1.
blueyed · Jul 25, 2017 · 869eed9 · 869eed9
1 parent 70d9f86
commit 869eed9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/_pytest/skipping.py b/_pytest/skipping.py
@@ -382,4 +382,4 @@ def show_skipped(terminalreporter, lines):
                     reason = reason[9:]
                 lines.append(
                     "SKIP [%d] %s:%d: %s" %
-                    (num, fspath, lineno, reason))
+                    (num, fspath, lineno + 1, reason))
diff --git a/changelog/2548.bugfix b/changelog/2548.bugfix
@@ -0,0 +1 @@
+Fix lineno offset in show_skipped.
diff --git a/testing/test_skipping.py b/testing/test_skipping.py
@@ -708,7 +708,7 @@ def doskip():
     )
     result = testdir.runpytest('-rs')
     result.stdout.fnmatch_lines([
-        "*SKIP*2*conftest.py:3: test",
+        "*SKIP*2*conftest.py:4: test",
     ])
     assert result.ret == 0