Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codestyle issue NoCommentFixer.php #126

Closed
PiotrFedak opened this issue Jun 19, 2024 · 4 comments
Closed

Codestyle issue NoCommentFixer.php #126

PiotrFedak opened this issue Jun 19, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@PiotrFedak
Copy link

Error code

PHP Fatal error: Class Blumilk\Codestyle\Fixers\NoCommentFixer contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PhpCsFixer\Fixer\ConfigurableFixerInterface::configure) in /home/runner/work/blt/blt/vendor/blumilksoftware/codestyle/src/Fixers/NoCommentFixer.php on line 19 Script ./vendor/bin/php-cs-fixer fix --dry-run --diff --config codestyle.php handling the cs event returned with error code 255 Error: Process completed with exit code 255.

@PiotrFedak PiotrFedak added the bug Something isn't working label Jun 19, 2024
@PiotrFedak PiotrFedak changed the title Codestyle issue Codestyle issue NoCommentFixer.php Jun 19, 2024
@krzysztofrewak krzysztofrewak transferred this issue from blumilksoftware/blt Jun 19, 2024
@JakubKermes
Copy link

final class NoCommentFixer extends AbstractFixer implements ConfigurableFixerInterface
{
    public function getConfigurationDefinition(): FixerConfigurationResolver
    {
        return new FixerConfigurationResolver([
            (new FixerOptionBuilder("doc_comment", "Docblock comments should be removed."))
                ->setAllowedTypes(["bool"])
                ->setDefault(false)
                ->getOption(),
        ]);
    }
    public function configure(array $configuration):void
    {
    }

this seems to resolve problem, but we can also limit version of cs fixer to 3.59.2

    "friendsofphp/php-cs-fixer": "v3.59.2",

from 3.59.3, which also works

@krzysztofrewak
Copy link
Member

Duplicate of #124.

@krzysztofrewak krzysztofrewak closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2024
@mtracz
Copy link
Member

mtracz commented Jun 20, 2024

@JakubKermes, @PiotrFedak
New release v3.2.1 should works now.

@PiotrFedak
Copy link
Author

@mtracz yes, works fine after new release, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants